Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 2/4] mfd: twl6040: fix error return code | Date | Wed, 6 Aug 2014 22:12:15 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Convert a zero return value on error to a negative one, as returned elsewhere in the function.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/mfd/twl6040.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/twl6040.c b/drivers/mfd/twl6040.c index f9c06c5..9687645 100644 --- a/drivers/mfd/twl6040.c +++ b/drivers/mfd/twl6040.c @@ -679,6 +679,7 @@ static int twl6040_probe(struct i2c_client *client, if (twl6040->rev < 0) { dev_err(&client->dev, "Failed to read revision register: %d\n", twl6040->rev); + ret = twl6040->rev; goto gpio_err; }
| |