Messages in this thread | | | Date | Wed, 6 Aug 2014 15:05:31 -0400 | From | Murali Karicheri <> | Subject | Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs |
| |
On 08/06/2014 01:30 PM, Jason Gunthorpe wrote: > On Wed, Aug 06, 2014 at 01:09:41PM -0400, Murali Karicheri wrote: > >>>> Yes it works with tuning enabled. Tuning happens afterwards. The >>>> 'limiting mrrs to 256' below is from my patch. >>> >>> That seems backwards to me... >> Rational? The tuning is reading mrrs and set mps to less than or >> equal to mrss. So adding this before make sure mrrs used is below >> keystones's limit. > > The tuning process adjusts the parameters however it sees fit, todays > algorithm might not increase a BIOS set MRRS, but tomorrow's could. > > The quirk should be after the tuning to ensure the MRRS is limited.. > > Jason Ok. I see it.
The latest possible quirk application point seems to be before enabling the ep device. A change in macro as below will achieve this and it works.
-DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, quirk_limit_mrrs); +DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_limit_mrrs);
If this looks reasonable, I will repost my patch with this change.
regards,
Murali
| |