Messages in this thread | | | Date | Wed, 6 Aug 2014 11:30:14 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] PCI: keystone: add a pci quirk to limit mrrs |
| |
On Wed, Aug 06, 2014 at 01:09:41PM -0400, Murali Karicheri wrote:
> >>Yes it works with tuning enabled. Tuning happens afterwards. The > >>'limiting mrrs to 256' below is from my patch. > > > >That seems backwards to me... > Rational? The tuning is reading mrrs and set mps to less than or > equal to mrss. So adding this before make sure mrrs used is below > keystones's limit.
The tuning process adjusts the parameters however it sees fit, todays algorithm might not increase a BIOS set MRRS, but tomorrow's could.
The quirk should be after the tuning to ensure the MRRS is limited..
Jason
| |