| Date | Wed, 6 Aug 2014 13:18:28 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH v2 7/7] fs/proc/task_mmu.c: shift "priv->task = NULL" from m_start() to m_stop() |
| |
On Tue, Aug 05, 2014 at 09:47:07PM +0200, Oleg Nesterov wrote: > 1. There is no reason to reset ->tail_vma in m_start(), if we return > IS_ERR_OR_NULL() it won't be used. > > 2. m_start() also clears priv->task to ensure that m_stop() won't use > the stale pointer if we fail before get_task_struct(). But this is > ugly and confusing, move this initialization in m_stop(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kirill A. Shutemov
|