| Date | Wed, 6 Aug 2014 13:17:18 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH v2 6/7] fs/proc/task_mmu.c: cleanup the "tail_vma" horror in m_next() |
| |
On Tue, Aug 05, 2014 at 09:47:03PM +0200, Oleg Nesterov wrote: > 1. Kill the first "vma != NULL" check. Firstly this is not possible, > m_next() won't be called if ->start() or the previous ->next() > returns NULL. > > And if it was possible the 2nd "vma != tail_vma" check is buggy, > we should not wrongly return ->tail_vma. > > 2. Make this function readable. The logic is very simple, we should > return check "vma != tail" once and return "vm_next || tail_vma". > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kirill A. Shutemov
|