lkml.org 
[lkml]   [2014]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ipc/shm: fix the historical/wrong mm->start_stack check
On 08/26, Cyrill Gorcunov wrote:
>
> On Mon, Aug 25, 2014 at 09:12:07PM +0200, Oleg Nesterov wrote:
> > + vma = find_vma(current->mm, addr);
> > + if (vma) {
> > + unsigned long end = addr + size;
> > +
> > + if (vma->vm_flags & VM_GROWSDOWN)
> > + end += PAGE_SIZE * 5;
> > +
> > + if (end < addr || end > vma->vm_start)
> > + goto invalid;
>
> Looks good to me, but I somehow missed in first version of the patch
> too the following aspect -- end > vma->vm_start? Maybe end >= vma->vm_end?

I think ">" is correct, the last byte is "addr + size - 1". Otherwise,
say, find_vma_intersection() is buggy. But this doesn't matter, please
see v3.

Oleg.



\
 
 \ /
  Last update: 2014-08-26 22:01    [W:0.045 / U:3.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site