Messages in this thread | | | Date | Tue, 26 Aug 2014 01:22:09 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH v2] ipc/shm: fix the historical/wrong mm->start_stack check |
| |
On Mon, Aug 25, 2014 at 09:12:07PM +0200, Oleg Nesterov wrote: > + vma = find_vma(current->mm, addr); > + if (vma) { > + unsigned long end = addr + size; > + > + if (vma->vm_flags & VM_GROWSDOWN) > + end += PAGE_SIZE * 5; > + > + if (end < addr || end > vma->vm_start) > + goto invalid;
Looks good to me, but I somehow missed in first version of the patch too the following aspect -- end > vma->vm_start? Maybe end >= vma->vm_end?
| |