lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/4] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree
On 08/06/2014 04:25 AM, Mikko Perttunen wrote:
> This adds the soctherm thermal sensing and management unit to the
> Tegra124 device tree along with the four thermal zones corresponding
> to the four thermal sensors provided by soctherm.

> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi

> + thermal-zones {

> + soctherm: soctherm@0,700e2000 {

> cpus {

The sort order of these nodes is wrong; nodes with reg should be sorted
according to the reg value. Nodes without reg should be sorted
alpha-numerically. That would place soctherm after sdhci@0,700b0600, and
thermal-zones before timer.

soctherm isn't a generic node name but sounds more like an identity;
thermal-sensor sounds like a better node name (but the node label can
still be soctherm if you want; label names don't show up in the DT ABI).

If these are the only issues, they can probably be fixed manually when
applying the patches, assuming a Tegra maintainer does it - I wouldn't
want to burden anyone else with that.


\
 
 \ /
  Last update: 2014-08-20 22:21    [W:0.286 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site