lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] usb: gadget: serial: remove PREFIX macro
Hello.

On 08/20/2014 07:54 PM, Felipe Balbi wrote:

>> Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with
>> the hardcoded ttyGS string.

>> This macro was mostly used in a few debug/warning messages and a lot of
>> hardcoded ttyGS existed beneath. It may have been used for renaming the
>> tty, but if done so most debug messages would have ignored this because
>> of the hardcoded strings.

>> Due to the fact the usage of this PREFIX instead of the hardcoded strings
>> in all debug calls would have resulted in a hard to read/grep code it
>> is removed completely.

>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>

> patch looks fine, can you resend with RFC in the subject ?

s/with/without/?

WBR, Sergei



\
 
 \ /
  Last update: 2014-08-20 19:21    [W:0.078 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site