Messages in this thread | | | Date | Wed, 20 Aug 2014 10:54:17 -0500 | From | Felipe Balbi <> | Subject | Re: [RFC] usb: gadget: serial: remove PREFIX macro |
| |
Hi,
On Fri, Jul 18, 2014 at 11:39:46AM +0200, Richard Leitner wrote: > Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with > the hardcoded ttyGS string. > > This macro was mostly used in a few debug/warning messages and a lot of > hardcoded ttyGS existed beneath. It may have been used for renaming the > tty, but if done so most debug messages would have ignored this because > of the hardcoded strings. > > Due to the fact the usage of this PREFIX instead of the hardcoded strings > in all debug calls would have resulted in a hard to read/grep code it > is removed completely. > > Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
patch looks fine, can you resend with RFC in the subject ?
-- balbi [unhandled content-type:application/pgp-signature] | |