Messages in this thread Patch in this message | | | Date | Sun, 17 Aug 2014 14:43:37 +0300 | From | Andreea-Cristina Bernat <> | Subject | [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer() |
| |
The "rcu_dereference()" call is used directly in a condition. Since its return value is never dereferenced it is recommended to use "rcu_access_pointer()" instead of "rcu_dereference()". Therefore, this patch makes the replacement.
The following Coccinelle semantic patch was used: @@ @@
( if( (<+... - rcu_dereference + rcu_access_pointer (...) ...+>)) {...} | while( (<+... - rcu_dereference + rcu_access_pointer (...) ...+>)) {...} )
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c index 155282e..8643003 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c @@ -1544,7 +1544,7 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter) rcu_read_lock(); - if (rcu_dereference(adapter->pnetdev->rx_handler_data) && + if (rcu_access_pointer(adapter->pnetdev->rx_handler_data) && (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE) == true)) { /* expire NAT2.5 entry */ nat25_db_expire(adapter); -- 1.9.1
| |