Messages in this thread Patch in this message | | | Date | Sun, 17 Aug 2014 00:27:48 +0530 | From | Hema Prathaban <> | Subject | [PATCH] staging: lustre: lustre: libcfs: do not use assignment in if condition |
| |
This patch fixes the following error using checkpatch.pl Error: do not use assignment in if condition
Signed-off-by: Hema Prathaban <hemaklnce@gmail.com> --- drivers/staging/lustre/lustre/libcfs/debug.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c index 43817be..5a5b7fc 100644 --- a/drivers/staging/lustre/lustre/libcfs/debug.c +++ b/drivers/staging/lustre/lustre/libcfs/debug.c @@ -314,9 +314,8 @@ libcfs_debug_str2mask(int *mask, const char *str, int is_subsys) if (!isspace(str[n-1])) break; matched = n; - - if ((t = sscanf(str, "%i%n", &m, &matched)) >= 1 && - matched == n) { + t = sscanf(str, "%i%n", &m, &matched); + if (t >= 1 && matched == n) { /* don't print warning for lctl set_param debug=0 or -1 */ if (m != 0 && m != -1) CWARN("You are trying to use a numerical value for the " -- 1.9.1
| |