Messages in this thread Patch in this message | | | Subject | Re: [RFC PATCH 06/10] scsi/sd: Delete extra scsi_show_extd_sense() in sd_print_sense_hdr() | From | Ewan Milne <> | Date | Fri, 15 Aug 2014 11:14:18 -0400 |
| |
On Fri, 2014-08-08 at 11:50 +0000, Yoshihiro YUNOMAE wrote: > sd_print_sense_hdr() calls scsi_show_extd_sense(), > but scsi_print_sense_hdr() also calls scsi_show_extd_sense(). > We can get same result, so we delete it. > > Note: > Calling scsi_show_extd_sense() is introduced in fdd8b297. > > Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com> > Cc: Hannes Reinecke <hare@suse.de> > Cc: Doug Gilbert <dgilbert@interlog.com> > Cc: Martin K. Petersen <martin.petersen@oracle.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: "James E.J. Bottomley" <JBottomley@parallels.com> > Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > --- > drivers/scsi/sd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 8d7204a..22dd214 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3286,8 +3286,6 @@ static void sd_print_sense_hdr(struct scsi_disk *sdkp, > struct scsi_sense_hdr *sshdr) > { > scsi_print_sense_hdr(sdkp->device, sdkp->disk->disk_name, sshdr); > - scsi_show_extd_sense(sdkp->device, sdkp->disk->disk_name, > - sshdr->asc, sshdr->ascq); > } > > static void sd_print_result(struct scsi_disk *sdkp, int result) > > --
Looks fine, but again, Hannes should probably update his tree.
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
| |