lkml.org 
[lkml]   [2014]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/4] mfd: arizona: Add additional dummy IRQ callbacks
Date
We use a dummy IRQ chip to dispatch interrupts to the two seperate IRQ
domains on the Arizona devices. Currently only the enable and disable
callbacks are defined however, there are some situations where additional
callbacks will be used from the IRQ core, which currently results in an
NULL pointer deference. Add handlers for more of the IRQ callbacks and
combine these into a single function since they are all identical.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-irq.c | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c
index d420dbc..71e8f06 100644
--- a/drivers/mfd/arizona-irq.c
+++ b/drivers/mfd/arizona-irq.c
@@ -144,18 +144,17 @@ static irqreturn_t arizona_irq_thread(int irq, void *data)
return IRQ_HANDLED;
}

-static void arizona_irq_enable(struct irq_data *data)
-{
-}
-
-static void arizona_irq_disable(struct irq_data *data)
+static void arizona_irq_dummy(struct irq_data *data)
{
}

static struct irq_chip arizona_irq_chip = {
.name = "arizona",
- .irq_disable = arizona_irq_disable,
- .irq_enable = arizona_irq_enable,
+ .irq_disable = arizona_irq_dummy,
+ .irq_enable = arizona_irq_dummy,
+ .irq_ack = arizona_irq_dummy,
+ .irq_mask = arizona_irq_dummy,
+ .irq_unmask = arizona_irq_dummy,
};

static int arizona_irq_map(struct irq_domain *h, unsigned int virq,
--
1.7.2.5


\
 
 \ /
  Last update: 2014-08-12 16:21    [W:0.076 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site