| Date | Wed, 9 Jul 2014 09:32:21 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [RFC/PATCH RESEND -next 12/21] mm: util: move krealloc/kzfree to slab_common.c |
| |
On Wed, 9 Jul 2014, Andrey Ryabinin wrote:
> To avoid false positive reports in kernel address sanitizer krealloc/kzfree > functions shouldn't be instrumented. Since we want to instrument other > functions in mm/util.c, krealloc/kzfree moved to slab_common.c which is not > instrumented. > > Unfortunately we can't completely disable instrumentation for one function. > We could disable compiler's instrumentation for one function by using > __atribute__((no_sanitize_address)). > But the problem here is that memset call will be replaced by instumented > version kasan_memset since currently it's implemented as define:
Looks good to me and useful regardless of the sanitizer going in.
Acked-by: Christoph Lameter <cl@linux.com>
|