lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/PATCH RESEND -next 01/21] Add kernel address sanitizer infrastructure.
    On 07/09/2014 04:29 AM, Andrey Ryabinin wrote:
    > +void __init kasan_alloc_shadow(void)
    > +{
    > + unsigned long lowmem_size = (unsigned long)high_memory - PAGE_OFFSET;
    > + unsigned long shadow_size;
    > + phys_addr_t shadow_phys_start;
    > +
    > + shadow_size = lowmem_size >> KASAN_SHADOW_SCALE_SHIFT;

    This calculation is essentially meaningless, and it's going to break
    when we have sparse memory situations like having big holes. This code
    attempts to allocate non-sparse data for backing what might be very
    sparse memory ranges.

    It's quite OK for us to handle configurations today where we have 2GB of
    RAM with 1GB at 0x0 and 1GB at 0x10000000000. This code would attempt
    to allocate a 128GB shadow area for this configuration with 2GB of RAM. :)

    You're probably going to get stuck doing something similar to the
    sparsemem-vmemmap code does. You could handle this for normal sparsemem
    by adding a shadow area pointer to the memory section.
    Or, just vmalloc() (get_vm_area() really) the virtual space and then
    make sure to allocate the backing store before you need it (handling the
    faults would probably get too tricky).


    \
     
     \ /
      Last update: 2014-07-09 23:21    [W:4.026 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site