Messages in this thread Patch in this message | | | From | Varka Bhadram <> | Subject | [PATCH v2] drivers/gpio/gpio-sch311x: check return value of gpiochip remove() | Date | Fri, 4 Jul 2014 12:32:59 +0530 |
| |
This patch eliminates the following warning
drivers/gpio/gpio-sch311x.c: In function ‘sch311x_gpio_probe’: drivers/gpio/gpio-sch311x.c:286:18: warning: ignoring return value of ‘gpiochip_remove’, declared with attribute warn_unused_result
Signed-off-by: Varka Bhadram <varkab@cdac.in> --- drivers/gpio/gpio-sch311x.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-sch311x.c b/drivers/gpio/gpio-sch311x.c index f942b80..74282b9 100644 --- a/drivers/gpio/gpio-sch311x.c +++ b/drivers/gpio/gpio-sch311x.c @@ -232,7 +232,7 @@ static int sch311x_gpio_probe(struct platform_device *pdev) struct sch311x_pdev_data *pdata = pdev->dev.platform_data; struct sch311x_gpio_priv *priv; struct sch311x_gpio_block *block; - int err, i; + int err, i, ret = 0; /* we can register all GPIO data registers at once */ if (!request_region(pdata->runtime_reg + GP1, 6, DRV_NAME)) { @@ -282,8 +282,13 @@ static int sch311x_gpio_probe(struct platform_device *pdev) exit_err: release_region(pdata->runtime_reg + GP1, 6); /* release already registered chips */ - for (--i; i >= 0; i--) - gpiochip_remove(&priv->blocks[i].chip); + for (--i; i >= 0; i--) { + ret = gpiochip_remove(&priv->blocks[i].chip); + + WARN(ret, "%s(): gpiochip_remove() failed, ret=%d\n", + __func__, ret); + } + return err; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |