Messages in this thread | | | Date | Thu, 31 Jul 2014 17:32:05 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 2/2] dma: imx-sdma: Adding tasklet_kill() in sdma_remove function. |
| |
On Wed, Jul 30, 2014 at 06:41:15PM +0530, Vignesh Raman wrote: > Several dma drivers calls tasklet_kill() in remove function. This is missing in > imx driver, so adding tasklet_kill() in sdma_remove function. And why should we do that ?
-- ~Vinod
> > Signed-off-by: Vignesh Raman <Vignesh_Raman@mentor.com> > --- > drivers/dma/imx-sdma.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 1360b9d..974337f 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1636,12 +1636,19 @@ static int sdma_remove(struct platform_device *pdev) > struct sdma_engine *sdma = platform_get_drvdata(pdev); > struct resource *iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); > int irq = platform_get_irq(pdev, 0); > + int i; > > dma_async_device_unregister(&sdma->dma_device); > kfree(sdma->script_addrs); > free_irq(irq, sdma); > iounmap(sdma->regs); > release_mem_region(iores->start, resource_size(iores)); > + /* Kill the tasklet */ > + for (i = 0; i < MAX_DMA_CHANNELS; i++) { > + struct sdma_channel *sdmac = &sdma->channel[i]; > + > + tasklet_kill(&sdmac->tasklet); > + } > kfree(sdma); > > platform_set_drvdata(pdev, NULL); > -- > 1.7.9.5 >
--
| |