lkml.org 
[lkml]   [2014]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dma: imx-sdma: use module_platform_driver for SDMA driver
On Wed, Jul 30, 2014 at 06:41:14PM +0530, Vignesh Raman wrote:
> Currently there is no module_exit declared in SDMA driver, so that once
> sdma module is inserted, it's shown with permanent attribute by lsmod,
> and it can't be removed.
> Use module_platform_driver to register/unregister SDMA driver and modify
> SDMA's remove operation, to make SDMA driver possible to be removed.
where is this bit below?

--
~Vinod
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
> drivers/dma/imx-sdma.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 14867e3..1360b9d 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1633,7 +1633,21 @@ err_irq:
>
> static int sdma_remove(struct platform_device *pdev)
> {
> - return -EBUSY;
> + struct sdma_engine *sdma = platform_get_drvdata(pdev);
> + struct resource *iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + int irq = platform_get_irq(pdev, 0);
> +
> + dma_async_device_unregister(&sdma->dma_device);
> + kfree(sdma->script_addrs);
> + free_irq(irq, sdma);
> + iounmap(sdma->regs);
> + release_mem_region(iores->start, resource_size(iores));
> + kfree(sdma);
> +
> + platform_set_drvdata(pdev, NULL);
> +
> + dev_info(&pdev->dev, "Removed...\n");
> + return 0;
> }
>
> static struct platform_driver sdma_driver = {
> --
> 1.7.9.5
>

--


\
 
 \ /
  Last update: 2014-07-31 14:41    [W:0.108 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site