Messages in this thread | | | Date | Wed, 23 Jul 2014 21:34:44 +0200 | From | Oleg Nesterov <> | Subject | [PATCH 0/2] ftrace: kill the dead code in trace_sched_switch.c |
| |
On 07/23, Oleg Nesterov wrote: > > This motivated me to try to find something else unused. And it seems that > almost all code in kernel/trace/trace_sched_switch.c is dead? Hmm, and > probably even event_context_switch... I'll recheck and send the patch.
No, event_context_switch can't simply go away. But afaics the only user is tracing_sched_switch_trace(), and the only caller of this function is probe_wakeup_sched_switch(). Looks a bit strange.
After this patch we should probably move tracing_sched_switch_trace() and tracing_sched_wakeup_trace() from trace_sched_switch.c to trace_sched_wakeup.c and make them static. And perhaps we can also move the rest of this code somewhere else and rm this file...
Oleg.
kernel/trace/trace.h | 3 - kernel/trace/trace_sched_switch.c | 88 ------------------------------------- 2 files changed, 0 insertions(+), 91 deletions(-)
| |