lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] edac: Remove fixmes in e7xxx_edac.c
From
On Tue, Jul 22, 2014 at 7:04 AM, Bjørn Mork <bjorn@mork.no> wrote:
>> - /* FIXME - should use PAGE_SHIFT */
>> - page = error_1b >> 6; /* convert the address to 4k page */
>> + page = error_1b >> PAGE_SHIFT; /* convert the address to 4k page */
>
> I just have to bite... Where did you get the idea that you can go
> around and "fix" FIMXE's like they were spelling errors?

Or apparently without thinking? Since "PAGE_SHIFT" does not have
the numerical value "6" your new code is obviously not equivalent to
the old.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-07-22 20:01    [W:0.081 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site