lkml.org 
[lkml]   [2014]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] edac: Remove fixmes in e7xxx_edac.c
Date
Nicholas Krause <xerofoify@gmail.com> writes:

> This removes two Page shift fixs me in this file and not checking
> if row is -1 in process_ce as it cannot be this value or be must
> exit this function by returning.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/edac/e7xxx_edac.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/edac/e7xxx_edac.c b/drivers/edac/e7xxx_edac.c
> index 3cda79b..563983f 100644
> --- a/drivers/edac/e7xxx_edac.c
> +++ b/drivers/edac/e7xxx_edac.c
> @@ -211,12 +211,13 @@ static void process_ce(struct mem_ctl_info *mci, struct e7xxx_error_info *info)
> edac_dbg(3, "\n");
> /* read the error address */
> error_1b = info->dram_celog_add;
> - /* FIXME - should use PAGE_SHIFT */
> - page = error_1b >> 6; /* convert the address to 4k page */
> + page = error_1b >> PAGE_SHIFT; /* convert the address to 4k page */

I just have to bite... Where did you get the idea that you can go
around and "fix" FIMXE's like they were spelling errors?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-07-23 11:41    [W:0.487 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site