| Date | Fri, 18 Jul 2014 12:22:13 -0400 | From | "John W. Linville" <> | Subject | Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use |
| |
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch.
Honestly, I prefer the macro -- it stands-out more. Maybe the style guidelines and/or checkpatch should change instead?
John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.
|