Messages in this thread | | | Date | Fri, 18 Jul 2014 11:46:49 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/3] mpt3sas, mpt2sas: fix scsi_add_host error handling problems in _scsih_probe |
| |
On Thu, Jul 17, 2014 at 02:39:30PM -0500, Robert Elliott wrote: > In _scsih_probe, propagate the return value from scsi_add_host. > In mpt3sas, avoid calling list_del twice if that returns an > error, which causes list_del corruption warnings if an error > is returned. > > Tested with blk-mq and scsi-mq patches to properly cleanup > from and propagate blk_mq_init_rq_map errors. > > Signed-off-by: Robert Elliott <elliott@hp.com>
Looks good. It would be even better if we'd have proper error values returned from mpt2/3sas_base_attach as well.
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |