Messages in this thread | | | Date | Fri, 18 Jul 2014 11:45:59 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag_set return values |
| |
On Thu, Jul 17, 2014 at 02:39:21PM -0500, Robert Elliott wrote: > Two of the blk-mq based drivers do not pass back the return value > from blk_mq_alloc_tag_set, instead just returning -ENOMEM. > > blk_mq_alloc_tag_set returns -EINVAL if the number of queues or > queue depth is bad. -ENOMEM implies that retrying after freeing some > memory might be more successful, but that won't ever change > in the -EINVAL cases. > > Change the null_blk and mtip32xx drivers to pass along > the return value. > > Signed-off-by: Robert Elliott <elliott@hp.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |