lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/9] usb: phy: am335x: setup the gen_phy function pointers _before_ adding the phy
On Fri, Jul 18, 2014 at 11:31:28AM +0200, Lothar Waßmann wrote:
> Make sure all parameters are correctly set up before registering the
> PHY with the USB framework.
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> drivers/usb/phy/phy-am335x.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c
> index 91c71ab..6522fa7 100644
> --- a/drivers/usb/phy/phy-am335x.c
> +++ b/drivers/usb/phy/phy-am335x.c
> @@ -56,11 +56,12 @@ static int am335x_phy_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> + am_phy->usb_phy_gen.phy.init = am335x_init;
> + am_phy->usb_phy_gen.phy.shutdown = am335x_shutdown;
> +
> ret = usb_add_phy_dev(&am_phy->usb_phy_gen.phy);
> if (ret)
> return ret;
> - am_phy->usb_phy_gen.phy.init = am335x_init;
> - am_phy->usb_phy_gen.phy.shutdown = am335x_shutdown;
>
> platform_set_drvdata(pdev, am_phy);
> device_init_wakeup(dev, true);

both of these need to be done before registering the PHY too.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-07-20 03:21    [W:0.149 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site