Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver | Date | Wed, 16 Jul 2014 10:39:36 +0200 |
| |
On Wednesday 16 July 2014 10:26:02 Antoine Ténart wrote: > + > +Required properties: > +- compatible: should be "chipidea,usb2" > +- reg: base address and length of the registers > +- interrupts: interrupt for the USB controller > + > +Optional properties: > +- clocks: reference to the USB clock > +- usb-phy: reference to the USB PHY
I think the phy reference should use the standard phy binding, using "phys" property to refer to a node that has a "#phy-cells" property.
It seems the code gets this right, but just the documentation is wrong.
> +- vbus-supply: reference to the VBUS regulator > +- dma-mask: DMA bit mask
No. Do not use "dma-mask" as a property, that is a pure Linux specific concept. The DT way to express this is to use the 'dma-ranges' property in the device's parent to describe any bus-related restrictions, and for the driver to ask for a mask that matches what the hardware is capable of (which may be smaller or larger than what the bus supports).
Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |