Messages in this thread Patch in this message | | | Date | Tue, 15 Jul 2014 22:49:11 +0530 | From | Himangi Saraogi <> | Subject | [PATCH] WMI: Remove unnecessary null test |
| |
This patch removes the null test on block. block is initialized at the beginning of the function to &wblock->gblock. Since wblock is dereferenced prior to the null test, wblock must be a valid pointer, and &wblock->gblock cannot be null.
The following Coccinelle script is used for detecting the change:
@r@ expression e,f; identifier g,y; statement S1,S2; @@
*e = &f->g <+... f->y ...+> *if (e != NULL || ...) S1 else S2
Signed-off-by: Himangi Saraogi <himangi774@gmail.com> --- To send to: Matthew Garrett <matthew.garrett@nebula.com>,platform-driver-x86@vger.kernel.org,linux-kernel@vger.kernel.org drivers/platform/x86/wmi.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 43d1329..737e56d 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -256,10 +256,6 @@ static acpi_status wmi_method_enable(struct wmi_block *wblock, int enable) block = &wblock->gblock; handle = wblock->handle; - if (!block) - return AE_NOT_EXIST; - - snprintf(method, 5, "WE%02X", block->notify_id); status = acpi_execute_simple_method(handle, method, enable); -- 1.9.1
| |