Messages in this thread | | | Date | Mon, 14 Jul 2014 01:30:47 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host |
| |
On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote: > Limiting max_lun to 255 will make the driver to _not_ respond to LUNs higher > than that; ie Well-known LUN won't work here. > Also the SCSI stack will be using REPORT LUNS anyway since you're > advertising SPC-2 compliance. So your driver runs into issues if Hyper-V > would ever return more than 256 LUNs with the REPORT LUN command or if any > of the LUNs has an addressing scheme other than > '0x00'. > I would suggest to raise this to the technical limit (ie the largest LUN > which the _protocol_ supports) and let REPORT LUNS deal with the actual > LUNs.
I suspect hypverv doesn't support anything more. For now I'd be inclined to just put it in ASAP and if your suggestion works out fix it up later, although I'll wait a bit for more review feedback.
| |