Messages in this thread | | | Date | Mon, 14 Jul 2014 08:17:37 +0200 | From | Hannes Reinecke <> | Subject | Re: [PATCH 7/7] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure |
| |
On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: > On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. > Correctly handle this. Note that there is sufficient sense information to > support scsi error handling even in this case. > > In this version of the patch I have addressed comments from > Christoph Hellwig <hch@infradead.org> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > Cc: <stable@vger.kernel.org> > --- > drivers/scsi/storvsc_drv.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 9342ba4..29d0329 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1018,6 +1018,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, > case ATA_12: > set_host_byte(scmnd, DID_PASSTHROUGH); > break; > + /* > + * On Some Windows hosts TEST_UNIT_READY command can return > + * SRB_STATUS_ERROR, let the upper level code deal with it > + * based on the sense information. > + */ > + case TEST_UNIT_READY: > + break; > default: > set_host_byte(scmnd, DID_TARGET_FAILURE); > } > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |