lkml.org 
[lkml]   [2014]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext
From
Date
Our current handling of fs/vs is really weird.  The best may very well be to explicitly save and restore both fs and he as part of Andi's patchset to support wrxsbase.

On July 11, 2014 7:21:54 PM PDT, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>On Fri, Jul 11, 2014 at 9:29 AM, Andy Lutomirski <luto@amacapital.net>
>wrote:
>> As far as I can tell, these fields have been set to zero on save and
>> ignored on restore since Linux was imported into git. Rename them
>> '__pad1' and '__pad2' to avoid confusion and to allow them to be
>> recycled some day.
>
>Shouldn't we actually try to save/restore gs/fs properly? Admittedly,
>changing them in the signal handler would be insane, but still.. See
>our context switching code with the whole segment selector vs base
>save/restore code. Hmm?
>
> Linus

--
Sent from my mobile phone. Please pardon brevity and lack of formatting.


\
 
 \ /
  Last update: 2014-07-12 05:21    [W:0.139 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site