Messages in this thread | | | Date | Fri, 11 Jul 2014 19:04:44 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext |
| |
On 07/11/2014 09:29 AM, Andy Lutomirski wrote: > diff --git a/arch/x86/include/uapi/asm/sigcontext.h b/arch/x86/include/uapi/asm/sigcontext.h > index 076b11f..df9908b 100644 > --- a/arch/x86/include/uapi/asm/sigcontext.h > +++ b/arch/x86/include/uapi/asm/sigcontext.h > @@ -177,8 +177,8 @@ struct sigcontext { > __u64 rip; > __u64 eflags; /* RFLAGS */ > __u16 cs; > - __u16 gs; > - __u16 fs; > + __u16 __pad2; /* Was called gs, but was always zero. */ > + __u16 __pad1; /* Was called fs, but was always zero. */ > __u16 ss; > __u64 err; > __u64 trapno;
I'm just wondering if this is likely to cause compile error in existing code. I guess worst case we can just revert this patch...
-hpa
| |