Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path. | Date | Tue, 24 Jun 2014 16:40:53 +0900 |
| |
Hi Masami,
On Mon, 23 Jun 2014 03:17:12 +0000, Masami Hiramatsu wrote: > Fix to add a missing pair of braces for error path. > Commit 36d789a4d75f (perf probe: Improve error message for > unknown member of data structure) introduced this bug. > > Without this fix, defining an event with global variables > is always failed, because it always returns -ENOENT if > the argument is not a local variable. > > ---- > # perf probe -na "vfs_read smp_found_config" > Error: Failed to add events. > ---- > > With this fix, you can set a global variable for the > argument of new event. > > ---- > # perf probe -na "vfs_read smp_found_config" > Added new event: > probe:vfs_read (on vfs_read with smp_found_config) > > You can now use it in all perf tools, such as: > > perf record -e probe:vfs_read -aR sleep 1 > ---- > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Reported-by: Patrick Palka <patrick@parcs.ath.cx> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: Jiri Olsa <jolsa@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
| |