lkml.org 
[lkml]   [2014]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path.
On Mon, Jun 23, 2014 at 03:17:12AM +0000, Masami Hiramatsu wrote:
> Fix to add a missing pair of braces for error path.
> Commit 36d789a4d75f (perf probe: Improve error message for
> unknown member of data structure) introduced this bug.
>
> Without this fix, defining an event with global variables
> is always failed, because it always returns -ENOENT if
> the argument is not a local variable.
>
> ----
> # perf probe -na "vfs_read smp_found_config"
> Error: Failed to add events.
> ----
>
> With this fix, you can set a global variable for the
> argument of new event.
>
> ----
> # perf probe -na "vfs_read smp_found_config"
> Added new event:
> probe:vfs_read (on vfs_read with smp_found_config)
>
> You can now use it in all perf tools, such as:
>
> perf record -e probe:vfs_read -aR sleep 1
> ----

queued for perf/urgent

thanks,
jirka


\
 
 \ /
  Last update: 2014-06-24 12:01    [W:0.071 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site