Messages in this thread | | | From | "Ren, Qiaowei" <> | Subject | RE: [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface | Date | Tue, 24 Jun 2014 02:53:12 +0000 |
| |
On 2014-06-24, Andy Lutomirski wrote: >> + /* Make bounds tables and bouds directory unlocked. */ >> + if (vm_flags & VM_LOCKED) >> + vm_flags &= ~VM_LOCKED; > > Why? I would expect MCL_FUTURE to lock these. > Andy, I was just a little confused about LOCKED & POPULATE earlier and I thought VM_LOCKED is not necessary for MPX specific bounds tables. Now, this checking should be removed, and there should be mm_populate() for VM_LOCKED case after mmap_region():
if (!IS_ERR_VALUE(addr) && (vm_flags & VM_LOCKED)) mm_populate(addr, len);
Thanks, Qiaowei
| |