Messages in this thread | | | From | "Ren, Qiaowei" <> | Subject | RE: [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information | Date | Thu, 19 Jun 2014 01:13:48 +0000 |
| |
On 2014-06-18, Borislav Petkov wrote: > On Wed, Jun 18, 2014 at 05:44:13PM +0800, Qiaowei Ren wrote: > > This whole insn decoding machinery above looks like adapted from > arch/x86/lib/insn.c. You should merge it with the generic code in > insn.c instead of homegrowing it here only for the purposes of MPX. > And if it doesn't work for your needs, you should should extend the > generic code to do so. I think we even talked about this last time. > > Also, make sure you run all your patches through checkpatch.pl before > submitting. > Petkov, as we discussed on initial version of this patchset, general insn framework didn't work out well and I have tried to use generic struct insn, insn_field, etc. for obvious benefits.
Thanks, Qiaowei
| |