lkml.org 
[lkml]   [2014]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 1/3] staging: rtl8188eu: core: Remove unnecessary conditionals
The variable 'pxmitbuf' is already set to NULL when entering the
function. We can remove the first conditional. When _rtw_queue_empty()
returns false, 'pxmitbuf' if not NULL. We can merge the second and
third conditional.

Signed-off-by: Thomas Vegas <thomas@grouk.net>
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index a113f0f..bb290a3 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -1226,9 +1226,7 @@ struct xmit_buf *rtw_alloc_xmitbuf_ext(struct xmit_priv *pxmitpriv)

spin_lock_irqsave(&pfree_queue->lock, irql);

- if (_rtw_queue_empty(pfree_queue) == true) {
- pxmitbuf = NULL;
- } else {
+ if (_rtw_queue_empty(pfree_queue) == false) {
phead = get_list_head(pfree_queue);

plist = phead->next;
@@ -1236,9 +1234,6 @@ struct xmit_buf *rtw_alloc_xmitbuf_ext(struct xmit_priv *pxmitpriv)
pxmitbuf = container_of(plist, struct xmit_buf, list);

rtw_list_delete(&(pxmitbuf->list));
- }
-
- if (pxmitbuf != NULL) {
pxmitpriv->free_xmit_extbuf_cnt--;

pxmitbuf->priv_data = NULL;
--
1.8.5.5


\
 
 \ /
  Last update: 2014-06-22 13:41    [W:0.043 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site