lkml.org 
[lkml]   [2014]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: MIPS: Add MSI support for XLP9XX
On Tue, Jun 10, 2014 at 01:31:04AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=d66f3f0e10b49df8d0cc0d8eb5bf2ef9863a33cf
> Commit: d66f3f0e10b49df8d0cc0d8eb5bf2ef9863a33cf
> Parent: 1c98398662c9b4e2f03f64344f83dd6cb14e0420
> Refname: refs/heads/master
> Author: Ganesan Ramalingam <ganesanr@broadcom.com>
> AuthorDate: Fri May 9 16:35:49 2014 +0530
> Committer: Ralf Baechle <ralf@linux-mips.org>
> CommitDate: Fri May 30 16:51:02 2014 +0200
>
> MIPS: Add MSI support for XLP9XX

...

> + if (cpu_is_xlp9xx()) {
> + val = ((node * nlm_threads_per_node()) << 7 |
> + PIC_PCIE_MSIX_IRQ(link) << 1 | 0 << 0);

Should this be..

val = ((node * nlm_threads_per_node()) << 7 |
PIC_PCIE_MSIX_IRQ(link) << 1);
val &= ~(1 << 0);

perhaps ? because shifting a zero is a nop, as is ORing it.

Dave


\
 
 \ /
  Last update: 2014-06-18 02:41    [W:0.206 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site