Messages in this thread | | | Date | Wed, 7 May 2014 22:19:41 +0200 | From | Michael Brunner <> | Subject | Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog |
| |
On Thu, 24 Apr 2014 08:15:40 -0700, Guenter Roeck <linux@roeck-us.net> wrote: > On Thu, Apr 24, 2014 at 03:49:19PM +0200, gundberg wrote: > > Use the prescaler index, rather than its value, to configure the > > watchdog. This will prevent a mismatch with the prescaler used to > > calculate the cycles. > > > > Signed-off-by: Per Gundberg <per.gundberg@icomera.com> > > Good catch. Looks correct to me. Michael, any comments ? > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Setting the prescaler incorrectly this way can cause the system to reboot nearly immediately when activating the watchdog - not good. This should also be applied to the stable revisions as this code is included since 3.11.
Reviewed-by: Michael Brunner <michael.brunner@kontron.com> Tested-by: Michael Brunner <michael.brunner@kontron.com>
Thanks, Michael
| |