lkml.org 
[lkml]   [2014]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog
On Thu, 24 Apr 2014 08:15:40 -0700, Guenter Roeck <linux@roeck-us.net>
wrote:
> On Thu, Apr 24, 2014 at 03:49:19PM +0200, gundberg wrote:
> > Use the prescaler index, rather than its value, to configure the
> > watchdog. This will prevent a mismatch with the prescaler used to
> > calculate the cycles.
> >
> > Signed-off-by: Per Gundberg <per.gundberg@icomera.com>
>
> Good catch. Looks correct to me. Michael, any comments ?
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Setting the prescaler incorrectly this way can cause the system to
reboot nearly immediately when activating the watchdog - not good.
This should also be applied to the stable revisions as this code is
included since 3.11.

Reviewed-by: Michael Brunner <michael.brunner@kontron.com>
Tested-by: Michael Brunner <michael.brunner@kontron.com>

Thanks,
Michael


\
 
 \ /
  Last update: 2014-05-07 23:01    [W:0.044 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site