lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog
On Thu, Apr 24, 2014 at 03:49:19PM +0200, gundberg wrote:
> Use the prescaler index, rather than its value, to configure the watchdog.
> This will prevent a mismatch with the prescaler used to calculate the cycles.
>
> Signed-off-by: Per Gundberg <per.gundberg@icomera.com>

Good catch. Looks correct to me. Michael, any comments ?

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/watchdog/kempld_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- src/drivers/watchdog/kempld_wdt.c.orig 2014-04-24 07:32:08.463745055 +0000
> +++ src/drivers/watchdog/kempld_wdt.c 2014-04-24 07:34:09.839739808 +0000
> @@ -163,7 +163,7 @@ static int kempld_wdt_set_stage_timeout(
> kempld_get_mutex(pld);
> stage_cfg = kempld_read8(pld, KEMPLD_WDT_STAGE_CFG(stage->id));
> stage_cfg &= ~STAGE_CFG_PRESCALER_MASK;
> - stage_cfg |= STAGE_CFG_SET_PRESCALER(prescaler);
> + stage_cfg |= STAGE_CFG_SET_PRESCALER(PRESCALER_21);
> kempld_write8(pld, KEMPLD_WDT_STAGE_CFG(stage->id), stage_cfg);
> kempld_write32(pld, KEMPLD_WDT_STAGE_TIMEOUT(stage->id),
> stage_timeout);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


\
 
 \ /
  Last update: 2014-04-24 18:01    [W:0.056 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site