| From | Hans de Goede <> | Subject | Re: [PATCH v3 00/20] USB support for Armada 38x and Armada 375 | Date | Wed, 7 May 2014 08:33:10 +0000 (UTC) |
| |
Hi Gregory,
Gregory CLEMENT <gregory.clement <at> free-electrons.com> writes:
> This patch set adds the USB support for the Armada 38x Armada > 375. These SoCs use an xHCI but still need specific initialization, > mainly to setup the windows memory on the mbus. They also use the same > controller that the other mvebu SoC for EHCI.
<snip>
> Gregory CLEMENT (20): > usb: ehci-orion: Fix clock reference leaking > usb: ehci-orion: Add the optional PHY support
If you're using a proper phy driver, do you really need a soc specific ehci driver? I've spend a lot of time during the last release cycle to make ehci-platform a lot more generic, including adding (optional) phy support to it. It would be great if the new Armada SoCs could use ehci-platform instead of extending ehci-orion to cover more models (ideally most ehci-foo drivers would go away completely). I've no idea how feasible it is to use ehci-platform in your case, but IMHO it should at least be considered.
Regards,
Hans
|