lkml.org 
[lkml]   [2014]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] phy: exynos-mipi-video: Use PTR_ERR_OR_ZERO
Hi Sachin,

On 29/05/14 08:30, Sachin Kamat wrote:
> PTR_ERR_OR_ZERO simplifies the code.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> drivers/phy/phy-exynos-mipi-video.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
> index ff026689358c..6d6bcf52a10e 100644
> --- a/drivers/phy/phy-exynos-mipi-video.c
> +++ b/drivers/phy/phy-exynos-mipi-video.c
> @@ -9,6 +9,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/err.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> @@ -149,10 +150,8 @@ static int exynos_mipi_video_phy_probe(struct platform_device *pdev)
>
> phy_provider = devm_of_phy_provider_register(dev,
> exynos_mipi_video_phy_xlate);
> - if (IS_ERR(phy_provider))
> - return PTR_ERR(phy_provider);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(phy_provider);

I'm not convinced this is actually an improvement. For me it sounds more
like obfuscation of the code and reminds me the infamous IS_ERR_OR_NULL()
macro. I'd personally not introduce this change, but if Kishon thinks it's
good I won't object to merging it.

--
Thanks,
Sylwester


\
 
 \ /
  Last update: 2014-05-30 15:41    [W:0.083 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site