Messages in this thread | | | Date | Fri, 30 May 2014 10:13:02 +0200 | From | Hans de Goede <> | Subject | Re: [PATCH 3/3] phy: sun4i-usb: Use PTR_ERR_OR_ZERO |
| |
Hi,
On 05/29/2014 08:30 AM, Sachin Kamat wrote: > PTR_ERR_OR_ZERO simplifies the code. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/phy/phy-sun4i-usb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c > index 115d8d5190d5..7a4ea552f621 100644 > --- a/drivers/phy/phy-sun4i-usb.c > +++ b/drivers/phy/phy-sun4i-usb.c > @@ -22,6 +22,7 @@ > */ > > #include <linux/clk.h> > +#include <linux/err.h> > #include <linux/io.h> > #include <linux/kernel.h> > #include <linux/module.h> > @@ -306,10 +307,8 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev) > > dev_set_drvdata(dev, data); > phy_provider = devm_of_phy_provider_register(dev, sun4i_usb_phy_xlate); > - if (IS_ERR(phy_provider)) > - return PTR_ERR(phy_provider); > > - return 0; > + return PTR_ERR_OR_ZERO(phy_provider); > } > > static const struct of_device_id sun4i_usb_phy_of_match[] = { >
Looks good:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
| |