Messages in this thread | | | From | Jiri Olsa <> | Subject | [RFC/PATCH 0/2] perf tools: Factor sort elide | Date | Fri, 23 May 2014 17:15:45 +0200 |
| |
hi, factoring the elide code to make perf_hpp__should_skip function cheap call/check again.
Also I was wondering.. do we want to get rid of sort_entry structs in favor of perf_hpp__* stuff? Any plans?
I'm sending this a RFC, since any other such refactoring would change this stuff for sure as well ;-).
thanks, jirka
Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Stephane Eranian <eranian@google.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/perf/ui/browsers/hists.c | 8 ++++---- tools/perf/util/hist.h | 8 +++++++- tools/perf/util/sort.c | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------- tools/perf/util/sort.h | 2 +- 4 files changed, 67 insertions(+), 53 deletions(-)
| |