lkml.org 
[lkml]   [2014]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] intel_rapl: Correct hotplug correction
Date
From: Borislav Petkov <bp@suse.de>

So 009f225ef050 ("powercap, intel-rapl: Fix CPU hotplug callback
registration") says how get_/put_online_cpus() should be replaced with
this cpu_notifier_register_begin/_done().

But they're still there so what's up?

Let me do what was supposed to be done.

Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
---
drivers/powercap/intel_rapl.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index d9a0770b6c73..9055f3df1f64 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1377,8 +1377,6 @@ static int __init rapl_init(void)

cpu_notifier_register_begin();

- /* prevent CPU hotplug during detection */
- get_online_cpus();
ret = rapl_detect_topology();
if (ret)
goto done;
@@ -1390,7 +1388,6 @@ static int __init rapl_init(void)
}
__register_hotcpu_notifier(&rapl_cpu_notifier);
done:
- put_online_cpus();
cpu_notifier_register_done();

return ret;
--
1.9.0


\
 
 \ /
  Last update: 2014-05-24 08:41    [W:0.109 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site