Messages in this thread Patch in this message | | | From | Rickard Strandqvist <> | Subject | [PATCH] arch: cris: arch-v32: drivers: axisflashmap.c: Cleaning up inconsistent NULL checks | Date | Fri, 23 May 2014 00:00:09 +0200 |
| |
Cleaning up inconsistent NULL checks. There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> --- arch/cris/arch-v32/drivers/axisflashmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/cris/arch-v32/drivers/axisflashmap.c b/arch/cris/arch-v32/drivers/axisflashmap.c index 28dd771..e359cd7 100644 --- a/arch/cris/arch-v32/drivers/axisflashmap.c +++ b/arch/cris/arch-v32/drivers/axisflashmap.c @@ -487,7 +487,7 @@ static int __init init_axis_flash(void) axis_partitions[pidx].offset = offset + ptable->offset; #ifdef CONFIG_ETRAX_NANDFLASH - if (main_mtd->type == MTD_NANDFLASH) { + if (main_mtd && main_mtd->type == MTD_NANDFLASH) { axis_partitions[pidx].size = (((ptable+1)->offset == PARTITIONTABLE_END_MARKER) ? -- 1.7.10.4
| |