lkml.org 
[lkml]   [2014]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V5] PM/OPP: discard duplicate OPPs
Date
On Wednesday, May 21, 2014 09:33:42 AM Viresh Kumar wrote:
> On 21 May 2014 02:39, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >> + /* Duplicate OPPs ? */
> >> + if (new_opp->rate == opp->rate) {
> >> + int ret = (new_opp->u_volt == opp->u_volt) && opp->available ?
> >> + 0 : -EEXIST;
> >
> > The parens are not necessary. And is the direction correct?
>
> What do you mean by direction here ?

The case in which we want to return 0. Never mind, it's OK. The parens are still
not necessary, though.


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.


\
 
 \ /
  Last update: 2014-05-23 18:41    [W:0.044 / U:2.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site