On 21 May 2014 02:39, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >> + /* Duplicate OPPs ? */ >> + if (new_opp->rate == opp->rate) { >> + int ret = (new_opp->u_volt == opp->u_volt) && opp->available ? >> + 0 : -EEXIST; > > The parens are not necessary. And is the direction correct?