Messages in this thread | | | Date | Sat, 17 May 2014 11:41:20 +0200 | From | Wolfram Sang <> | Subject | Re: [Patch V2 5/9] I2C: Add smbus quick read/write helper function |
| |
On Mon, Apr 28, 2014 at 10:27:44PM +0800, Lan Tianyu wrote: > Add i2c_smbus_quick_write/read() helper function. These will be used > in the implementation of i2c ACPI address space handler. > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
We had such a function once but removed because of no users. Please check 67c2e66571c383404a5acd08189194da660da942 what it takes to bring them back. Especially missing are documentation updates...
> +s32 i2c_smbus_quick_write(const struct i2c_client *client)
... and I like the original function much better.
1) It is named *_write_quick which follows other function name patterns 2) It uses a parameter for the r/w bit. Make sense to me, since this bit is the information we send to the device. quick_read doesn't make sense to me. We don't receive a bit from the device.
[unhandled content-type:application/pgp-signature] | |