Messages in this thread | | | Date | Sat, 17 May 2014 19:15:56 +0200 | From | Wolfram Sang <> | Subject | Re: [Patch V2 5/9] I2C: Add smbus quick read/write helper function |
| |
> >2) It uses a parameter for the r/w bit. Make sense to me, since this bit > >is the information we send to the device. quick_read doesn't make sense > >to me. We don't receive a bit from the device. > > > > Hi Wolfram: > Great thanks for your review. Ok. I will follow commit 67c2e665 to > bring i2c_smbus_write_quick(struct i2c_client *client, u8 value) > back. > > BTW, how about i2c_probe_func_quick_read()? Should we replace it > with the original i2c_smbus_write_quick()?
As said above "quick_read doesn't make sense to me. We don't receive a bit from the device."
Start implementing and you will see why we don't need it :)
[unhandled content-type:application/pgp-signature]
| |